search

jhthorsen / json-validator

:cop: Validate data against a JSON schema
https://metacpan.org/release/JSON-Validator
56 stars 58 forks source link

remove 'replace' feature in bundle #194

Closed karenetheridge closed 2 years ago

karenetheridge commented 4 years ago

I was reading https://github.com/json-schema-org/json-schema-spec/issues/514 and https://github.com/json-schema-org/json-schema-spec/pull/628 and realized that the 'replace' option in bundle() is treating $ref like an inclusion, not a delegation, which is wrong. $refs should always remain as-is, so its sub-schema can be delegated to (evaluated in place), as described in that ticket.

I see that this feature was already deprecated once, in version 3.10, and then undeprecated although left undocumented, so there shouldn't be any serious ramifications here. So this ticket is mostly informational at this point.

jhthorsen commented 4 years ago

I'm using "replace" in JSON::Validator::OpenAPI::Mojolicious, so this cannot be done before I merge #189 and implement subclasses for OpenAPIv2 and OpenAPIv3.

jhthorsen commented 2 years ago

This feature is no longer present in #251.