search

jhthorsen / json-validator

:cop: Validate data against a JSON schema
https://metacpan.org/release/JSON-Validator
56 stars 58 forks source link

demonstration: broken schema registration #212

Closed karenetheridge closed 3 years ago

karenetheridge commented 4 years ago

This demonstrates the problem with broken schema caching and resolution.

I fixed the simple problem of the registry being lost when ::Schema objects are changed (see its commit message), but because of the order in which the new Schema object is constructed, ref resolution ends in an infinite loop.

jhthorsen commented 4 years ago

As mentioned in other channels: I think you should convert/merge whatever I started on in #211 with the code in #208.

I'm still keeping this PR open though, so I/we don't forget about it.

jhthorsen commented 3 years ago

Thanks for pointing me in the right direction. This is now fixed in "master".

karenetheridge commented 3 years ago

Yes, I provided you a fix for that months ago in another PR :)

jhthorsen commented 3 years ago

Yes, I provided you a fix for that months ago in another PR :)

Where? And why was this PR still open then?

karenetheridge commented 3 years ago

If I recall, you wanted me to reimplement it on top of some rearchitecting you were doing in a side branch, but doing so would have made the fix even harder.

I guess it doesn't really matter anymore.