Test against JSON-Schema-Test-Suite

jhthorsen / json-validator

:cop: Validate data against a JSON schema

https://metacpan.org/release/JSON-Validator

56 stars 57 forks source link

Test against JSON-Schema-Test-Suite #213

Closed merkys closed 3 years ago

merkys commented 4 years ago

I have recently found out about language-agnostic JSON schema test suite. It think they would be beneficial to json-validator both for regression testing and test-driven development.

jhthorsen commented 4 years ago

Ah! Nice to see there's new drafts in that repo :) J::V already use the official tests for draft04, but it would be fantastic to add tests for the other drafts as well.

Should probably bundle all the test files and refactor acceptance into a reusable test that can be loaded in draft4-acceptance.t, draft6-acceptance.t and draft7-acceptance.t.

karenetheridge commented 4 years ago

I have recently taken over maintainance of Test::JSON::Schema::Acceptance, and am renovating it with the intention of bringing it into the JSON-Validator distribution with updated tests across all drafts.

jhthorsen commented 3 years ago

I've now added t/draft[467]-acceptance.t which optionally use Test::JSON::Schema::Acceptance. There are some tests marked as TODO though. A quick summary:

I can't find a way to fix "float and integers are equal up to 64-bit representation limits". Please create a PR, or another issue if that is incorrect.
I think the issue with "Location-independent identifier with base URI change in subschema" is covered in #186.
I don't know how to do refRemote.json tests. I've created #224 as a follow up for that.

So since other issues exists, I'm going to close this one.

Sidenote: Annoying that the old refs aren't removed when I force push to a branch.

merkys commented 3 years ago

Thanks a lot @jhthorsen!