Catch duplicate "body" parameters

jhthorsen / json-validator

:cop: Validate data against a JSON schema

https://metacpan.org/release/JSON-Validator

57 stars 59 forks source link

Catch duplicate "body" parameters #97

Closed mohawk2 closed 6 years ago

mohawk2 commented 6 years ago

This should help a bit with #15.

jhthorsen commented 6 years ago

It seems like an awful lot of code to catch something that is obvious.

I will think about it, but will probably not reach any conclusion until next week.

jhthorsen commented 6 years ago

I don't think it's worth it, but I'll keep it open a bit longer for others to comment. Ask in the IRC channel for support and I will for sure reconsider.

mohawk2 commented 6 years ago

35 lines of code is "an awful lot" to catch something that's only obvious if you know to watch out for it?

jhthorsen commented 6 years ago

I've implemented the same logic in b09ff5a now, so I'm closing this issue.

Thanks for your contribution!

mohawk2 commented 6 years ago

@jhthorsen Does this belatedly mean #15 can also be closed?