search

jhthorsen / mojo-irc

IRC Client for the Mojo IOLoop
15 stars 13 forks source link

add irc_default event for unhandled irc responses #17

Closed Grinnz closed 9 years ago

Grinnz commented 9 years ago

irc_default event that is emitted for any irc response that is not handled in some other way, useful for debugging various irc responses.

jhthorsen commented 9 years ago

Why can't you just use MOJO_IRC_DEBUG=1 when debugging?

Grinnz commented 9 years ago

I didn't know about the debug flag, that is useful. But the default handler is more useful for long-term debugging as it will only handle "unexpected" messages.

jhthorsen commented 9 years ago

I will let @marcusramberg decide. I'm not convinced, but I'm also not against it.

jhthorsen commented 9 years ago

I've discussed this with @marcusramberg and we decided to reject this PR.