search

jhthorsen / mojo-irc

IRC Client for the Mojo IOLoop
14 stars 12 forks source link

Read buffer hanging on unknown numeric events #19

Closed Grinnz closed 9 years ago

Grinnz commented 9 years ago

Updated and added to the join test to expose an issue I've run into where the last few lines of the server response are delayed until further input is received from the server.

Grinnz commented 9 years ago

After some more testing it appears to be related to this line:

:ford.tamarou.com 275 test123 test123 :is connected via SSL (secure link)

I reordered and add more lines and it still stops reading after this line (or similar from other networks) until it receives more input from the server.

:alpha.irc.socialgamer.net 671 ZIRCBot ZIRCBot :is using a Secure Connection
Grinnz commented 9 years ago

The issue happens because these particular numerics don't have a translation in IRC::Utils and thus it breaks out of the while loop. I added a fix to the PR.

jhthorsen commented 9 years ago

I won't take this pull request. The reason is that i want to keep the t/data/welcome data as is. Please make a new pull request with a completely new data file, instead of modifying the existing test data.