jhthorsen / mojo-irc

IRC Client for the Mojo IOLoop
14 stars 12 forks source link

t/ua-mode.t fails #28

Closed jberger closed 7 years ago

jberger commented 7 years ago

As seen on cpan testers and I can report locally, t/ua-mode.t fails on the two user mode test attempts (4 total test failures, 2 per test attempt). I spent some time trying to debug but I couldn't figure out what was wrong.

jberger commented 7 years ago

I can say for sure that the guard in Test::Mojo::IRC is firing its timeout.

jhthorsen commented 7 years ago

Yeah, this one is tricky (at least for me), since it does not fail _all_thetime

jberger commented 7 years ago

It fails for me every time. Could it be a timing issue?

On Tue, Sep 6, 2016, 6:23 AM Jan Henning Thorsen notifications@github.com wrote:

Yeah, this one is tricky (at least for me), since it does not fail _all_thetime

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jhthorsen/mojo-irc/issues/28#issuecomment-244921842, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs6FWS5mqabRIIeq1A-EqOgHmGkYTZPks5qnU0ngaJpZM4J1csz .

jhthorsen commented 7 years ago

Soon available on CPAN. Thanks for reminding me 👍

jhthorsen commented 7 years ago

It's still failing, even if I can't make it fail locally:

http://www.cpantesters.org/cpan/report/0521b3d4-7481-11e6-8452-fb0924312fb7

while true; do prove -l t/ua-mode.t ; done
jberger commented 7 years ago

Honestly, give it a little bit too see if you get any more fails. In my experience slaven's smokers do that sometimes. I suspect he downloads the files as they are updated but reports them as they currently exist.

On Wed, Sep 7, 2016, 2:15 AM Jan Henning Thorsen notifications@github.com wrote:

Reopened #28 https://github.com/jhthorsen/mojo-irc/issues/28.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jhthorsen/mojo-irc/issues/28#event-780490083, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs6FaBnokzUDtRXncnVOCeeDD0roqH_ks5qnmSDgaJpZM4J1csz .