jhthorsen / mojo-irc

IRC Client for the Mojo IOLoop
14 stars 12 forks source link

Allowing testing with mocked server #7

Closed jhthorsen closed 10 years ago

jhthorsen commented 10 years ago

I wonder if using an environment variable is ok or if I should do Mojo::IRC->new(testing => 1);

marcusramberg commented 10 years ago

I would prefer an env variable instead of tainting the API.

jhthorsen commented 10 years ago

What does that mean (prefer env variable)? Do you accept the PR or do you want something to change?

marcusramberg commented 10 years ago

I accept it. I think the env is better than putting it in the constructor.

jhthorsen commented 10 years ago

\o/