Weaken circular reference in redis response parser

jhthorsen / mojo-redis

Non-blocking Redis driver using Mojo::IOLoop

https://metacpan.org/pod/Mojo::Redis

14 stars 11 forks source link

Closed Grinnz closed 3 years ago

Grinnz commented 3 years ago

Alternative to #58 in order to resolve #52.

TFBW commented 3 years ago

I have applied this patch locally and performed a test with Devel::MAT.

My code runs and serves no requests, then dumps memory (baseline): Heap contains 83010 objects
My code runs and serves 500 requests, then dumps memory, no weaken: Heap contains 429484 objects
My code runs and serves 500 requests, then dumps memory, with weaken: Heap contains 83048 objects

The net difference of 38 between baseline and with-weaken is not suspicious.

jhthorsen commented 3 years ago

I'm ok with using current_sub instead. What do you think?

jhthorsen commented 3 years ago

I'm fine with either of the solutions, though I would prefer the __SUB__ version, since I think it's a lot easier to read.

@Grinnz: I added you as comaint now, so you are free to merge and make a new release. I can also make a release after this is fixed, if you prefer.

jhthorsen commented 3 years ago

Picked #60 instead.