NGEfreak
commented
5 years ago I have a similar problem with content negotiation. Currently, a client has to set the full mime type like application/json in the Accept header. It doesn't work if he uses wildcards like */* or application/*. Also it doesn't work when the Accept header isn't set at all.
Here is a test case:
#!/usr/bin/env perl
use 5.010;
use strict;
use warnings;
use utf8;
use Test::More;
use Test::Mojo;
use Mojolicious::Lite;
get '/test' => sub {
shift->render( openapi => { foo => 'bar' }, status => 200 );
},
'test';
plugin 'OpenAPI' => {
url => 'data:///api.yml',
schema => 'v3',
};
my $t = Test::Mojo->new();
# Client accepts only application/json
$t->get_ok( '/test', { Accept => 'application/json' }, json => { foo => 'test' } )
->status_is(200)
->json_is( { foo => 'bar' } );
# Client accepts everything implicitly meaning Accept header isn't set or empty
$t->get_ok( '/test', json => { foo => 'test' } )
->status_is(200)
->json_is( { foo => 'bar' } );
# Client accepts everything explicitly
$t->get_ok( '/test', { Accept => '*/*' }, json => { foo => 'test' } )
->status_is(200)
->json_is( { foo => 'bar' } );
# Client accepts application/* explicitly
$t->get_ok( '/test', { Accept => 'application/*' }, json => { foo => 'test' } )
->status_is(200)
->json_is( { foo => 'bar' } );
done_testing;
__DATA__
@@ api.yml
openapi: 3.0.0
info:
title: Test
version: 0.0.0
paths:
/test:
get:
x-mojo-name: test
responses:
'200':
description: Test
content:
application/json:
schema:
properties:
foo:
type: string
The first call works as expected. The other three produce these errors:
No responses rules defined for type .No responses rules defined for type */*.No responses rules defined for type application/*.
jhthorsen
plk
martynd
I just converted a v2 spec to v3 which validates in the latest Swagger Editor without errors. I enabled V3 parsing, installed
YAML::XSand am on the version 2.11. Server started fine, no errors. Every request fails with 404 and:Before I delve into this, is there anything general you know of I need to change in code for v3?