this object belongs under components->schemas

jhthorsen / mojolicious-plugin-openapi

OpenAPI / Swagger plugin for Mojolicious

54 stars 44 forks source link

this object belongs under components->schemas #141

Closed HEM42 closed 4 years ago

HEM42 commented 4 years ago

Summary

The type of object created for the default response, is created as a Schema object, not a response object.

Also clean out a few keys that does not belong in OpenAPI spec v3

Motivation

Place the created default schema in the correct place as described in v3 specification, but also removal of few keys which does not belong there

References

https://swagger.io/specification/#schema
https://swagger.io/specification/#schemaObject
https://swagger.io/specification/#responsesObject

HEM42 commented 4 years ago

This doesn't fix the placement of the object under #/definitions/ when rendered, this is an issue with JSON::Validator (which Im currently trying to make a pr for as well)

HEM42 commented 4 years ago

I think this PR contains more than what the title says, but I'll take it anyways, after the requested work.

I have updated the description, so it reflects the changes, sorry about that