jhthorsen / mojolicious-plugin-webpack

Integrate your mojo app with webpack
13 stars 7 forks source link

Revert 1 dev filename fix #2

Closed mario-minati closed 4 years ago

mario-minati commented 4 years ago

Hello @JHT,

with the changes in 0.11 you introduced a bug, as the webpack.config.js uses '.dev.' instead of '.development.' in the filenames.

I created a small fix. Maybe you can merge it.

Best greets,

Mario Minati

jhthorsen commented 4 years ago

I think you did something weird when creating this PR. There's a revert of the fix that you made inside this PR, so https://github.com/jhthorsen/mojolicious-plugin-webpack/pull/2/files shows no changes.

jhthorsen commented 4 years ago

I made a more complete fix in 7e8fbae which is soon available on CPAN.

Thanks for letting me know!

mario-minati commented 4 years ago

Sorry for the wiredness, still learning working with github forks. Thanks for updating so quickly. :-)