sass-loader config options have changed

jhthorsen / mojolicious-plugin-webpack

Integrate your mojo app with webpack

13 stars 7 forks source link

sass-loader config options have changed #4

Closed mario-minati closed 3 years ago

mario-minati commented 4 years ago

Starting with sass-loader^8.0.0 the config settings have to change like this:

          {
            loader: 'sass-loader',
            options: {
              sassOptions: {
                includePaths: ['absolute/path/a', 'absolute/path/b'],
              },
            },
          },

There is no compatibility mode AFAIK.

References:

jhthorsen commented 4 years ago

Would you mind creating a PR with the changes that you want?

mario-minati commented 4 years ago

The problem is that there are two different config needs. It depends on the versioning of sass-loader. I can make a PR to completly fix it for 8.x.x, but than users with older versions will run into trouble.

The webpack.config.js is created before sass-loader is being installed (first time run). I'm not sure on completly rewriting the Builder.pm register functionallity.