search

jhthorsen / openapi-client

A client for talking to an Open API powered server
11 stars 17 forks source link

Fix POD to correctly explain how to amend base_url. #33

Closed cliveholloway closed 2 years ago

mohawk2 commented 2 years ago

Thanks!

jhthorsen commented 2 years ago

@mohawk2: The PR is invalid. I will have to revert it.

mohawk2 commented 2 years ago

@jhthorsen Are you going to steer @cliveholloway on what's wrong with it?

jhthorsen commented 2 years ago

@cliveholloway: Thanks for the PR! The issue was whitespace and some missing formatting in the POD. I've committed 200c2d5 now instead of asking you to create a new PR.

Hope that's ok.

cliveholloway commented 2 years ago

Oh, sure. I was looking at it, scratching my head for a second there, heh. Guess I should have actually looked at the generated POD. Apologies.

On Sat, Sep 25, 2021, 6:59 PM Jan Henning Thorsen @.***> wrote:

@cliveholloway https://github.com/cliveholloway: Thanks for the PR! The issue was whitespace and some missing formatting in the POD. I've committed 200c2d5 https://github.com/jhthorsen/openapi-client/commit/200c2d59718742bc1c3bab485f260fa7afa3d6ac now instead of asking you to create a new PR.

Hope that's ok.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhthorsen/openapi-client/pull/33#issuecomment-927195439, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWR2VO5WLPV6PM5HCFJ7BDUDZH4VANCNFSM5ESPHAWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.