Grouping issue: UI updates

joeflack4 commented 1 year ago

Overview

Various users gave us feedback. Here's what we need to fix. (Also adding other UI issues here.)

Sub-task list

[ ] #457
[x] #426
[ ] Recall is sensitivity, recall is proportion - do we rename this one? I wasn’t sure ~ Lisa
[ ] Ideas for improving legend Lisa wrote that you had ideas @stephanieshong
[ ] An item is the intentional, it is the thing you add specifically to the concept set, it’s the thing that is in the concept set definition. Is Definition a better name? Maybe use expansion instead of member? Chris suggests inclusion and extension
[ ] #455
[ ] #456
[x] #419
[x] #420
[ ] #421
[ ] #412
[x] #411
[ ] #386
[ ] #385
[ ] #384
[x] #381
[ ] #367
[x] #345
[x] #335
[x] #292
[ ] #326
[ ] #328
[ ] #90
[x] #330 CC_01, tester AZ
[x] #331
[x] #325
[x] #332
[x] #327
[x] #329
[x] #324
[x] (low) When the search drop down has focus, the caption gets half hidden. Bring the down arrow closer (either put on the left or make whole search window more narrow).
[x] Had issue saving as JSON. Could save as HTML but not JSON. CC_10 Tester CR (3/30 - asking CR to re-test)
[x] (high) Screen for example comparison remained white and did not populate. EC_01 tester CR (Is this the new bug that showed up 03/30?)
[x] (high) Add an “i” circled to column headers so user knows to go there for additional information (3/30 combining 5, 9, 10)
[x] (high) For the last two columns, if you click on those column headings it allows you to edit - need to make it clear to users. Maybe add instructions in the white space below? Add an “i” circled to column headers so user knows to go there for additional information (see 5 and 9 above)
[x] (high) Bug - Changes to one concept set are applied when another one is chosen
[x] (high) Header line of the table - make bigger or bolder or highlight the row a different color to make it evident it’s a table.
[x] (high) Make legend available without editing.
[x] (low) Prevent panel close being triggered by drag
[x] (high) Need more screen space. CC_03 tester RZ
[x] (high) Screen looks different on MS Windows than on Apple (space/screen issues on MS Windows) CC_04 Tester RZ
[x] Make pop-up windows or pop-over boxes movable with your mouse to move out of the way (things like the legend) - nice to have
[x] Attributes of codesets - if you split the window into top (stage changes) and lower half (table)
[x] Put the display legend on the left
[x] New feature: (not sure I’m capturing this correctly) If you want to add concept sets, you can do it to a particular concept set but if you take the original out of the mix, all the ones you selected disappears. You want a graphical for it (3/30 - removed per discussion)
[x] CC_13 from tester Bryan: Clicking on CSET COMPARISON didn't really do anything while on the example comparison. Instructions here should probably include directions to click on a specific code set, as other wise the Open in Enclave link is not available as there's no Code set information section available. (same as 8 above)

Sub-task details

User feedback collected & processed

[x] AndreaZ
[x] EileenK
[x] RichardZ
[x] CRoeder
[x] LisaE
[ ] Kim (hasn't tested as of 2023/03/15)
[ ] BryanL (still needs processing)
[ ] Margaret

Additional info

Feedback spreadsheet: https://docs.google.com/spreadsheets/d/1aMsGwV6JkWSMpaEwF4d7ne7aBLr2p-s_dRBWgjeHG3U/edit#gid=880790843
Eileen's feedback issue: https://github.com/jhu-bids/TermHub/issues/275

Sigfried commented 1 year ago

@joeflack4, it used to be if you hover over a sub-task, github gave an icon to allow turning it into a separate issue. I'm not seeing that anymore. Do you know why? If you look at #219, it obviously used to work there but doesn't now.

joeflack4 commented 1 year ago

@Sigfried Hey Siggie. This functionality is working on my end. Maybe a browser issue on your end? Maybe clear cache and log out / back in? edit: We solved the problem. It was that this UI is not functional when trying to edit an issue within the project board.

jhu-bids / TermHub