jhu-bids / TermHub

Web app and CLI tools for working with biomedical terminologies. https://github.com/orgs/jhu-bids/projects/9/views/7
https://bit.ly/termhub
GNU General Public License v3.0
11 stars 10 forks source link

Vocab refresh: Update `networkx` graphs #883

Closed joeflack4 closed 4 days ago

joeflack4 commented 2 months ago

addresses #977

Changes

DB Refresh: relationship_graph fix

General updates

Tests

Sigfried commented 4 days ago

@joeflack4, You got rid of some missing-in-between stuff, or just moved it. Yes -- it's not being used right now. I left the code in place in case we end up with problems where get_all_descendants is making the graph too big. It hasn't happened yet. Maybe we should just get rid of all missing-in-between code and leave a comment pointing to commit where it was last present in case we need to restore it someday.

In looking at it, I noticed that filled_gaps doesn't seem to appear in frontend code at all anymore. It does still appear in some test data.

Sigfried commented 4 days ago

I'm about to clean this all up.