search

jhu-cisst / cisst

JHU ERC CISST Library
http://github.com/jhu-cisst/cisst/wiki
Other
64 stars 47 forks source link

Minor fixes #68

Closed dlrdave closed 5 years ago

dlrdave commented 5 years ago

See the two commit comments for details.

First commit is an obvious test-only-code change so the test will pass.

Second commit is an AdvanceIfAutomatic call at the end of Startup. We've been using it since last summer -- it fixes incorrect data being returned from a component which has been started up, but which has not yet completed its first Run method call.

dlrdave commented 5 years ago

Ah ha. I see that the test suite here runs with ./cisstCommonTests -r -- I didn't try running it like that. I'm using ctest to drive the tests on Windows, and the default logger test uses the command line cisstCommonTests.exe "-r" "-i" "2" "-o" "2" "-t" "cmnLoggerTest::TestLoggerFileName" for this test. I'll run it with just -r too and come up with a different commit here.

pkazanzides commented 5 years ago

O.K. I believe your fix to the test was necessary if multiple iterations are run. My initial test did not handle that correctly. I'll wait to merge this until your next commit.

Regarding the change to mtsTask::StartupInternal, I am fine with that. I recall that we often called StateTable.Advance() in the "user" Startup method, so adding it to StartupInternal seems reasonable.

dlrdave commented 5 years ago

I'll close this one for now, and come up with a better logger tester fix for re-opening it. I may not be able to get to it until next weekend, though.