search

jhu-digital-manuscripts / rosa2

4 stars 2 forks source link

RMap export may report incorrect URL after exporting DiSCO #427

Closed jabrah closed 5 years ago

jabrah commented 5 years ago

Looks like in production, the research finding is persisted in RMap perfectly fine, however the URL reported to the user in the Export popup is incorrect. The user is presented with a URL formatted like:

https://rmap-hub.org/app/discos/<id>

This gives a 404 error. If /app is removed from the URL so it becomes https://rmap-hub.org/discos/<id>, then the URL resolves correctly in RMap.

jabrah commented 5 years ago

Note: this seems to be a bug in the viewer in how it constructs the RMap URL, since the RMap POST that sends the research finding returns and ARK ID, not the full URL of the DiSCO.

jabrah commented 5 years ago

This can be fixed with a configuration change in the production index.html

researchFinding: {
  rmap: {
    resolver: '/discos/'
  }
}

Or permanently change the value here https://github.com/jhu-digital-manuscripts/mirador/blob/aor-2/js/src/settings.js#L254