jhu-digital-manuscripts / rosa2

4 stars 2 forks source link

Landing page collection picker will not load correctly if starting the viewer outside of the landing page #452

Closed jabrah closed 3 years ago

jabrah commented 4 years ago

image

The collection picker will not be populated correctly if starting the viewer off of the landing page (the above image should show DLMM parent with Pizan and Rose collections). The collections still exist in the viewer and all of the data can still be viewed and searched, but the missing collection can't be singled out in the landing page.

Scenario: https://dlmm.library.jhu.edu/viewer/#rose/Harley4425/012v/image

This URL will open the DLMM viewer and show folio 12v from the Harley4425 manuscript from the Roman de la Rose collection. Once this page loads, hit the "Home" icon to navigate to the landing page. The collection picker element will not show the Rose collection. In this scenario, however, the Rose collection and its manuscripts will still show up when using the filters on the landing page.

This bug also occurs if a user navigates off the landing page then refreshes the viewer.

jabrah commented 4 years ago

The main problem seems to be our good old friend: async data loading. In the scenario described above, the viewer will try to add search services for parent collections of the loaded manifest while the collection data is still in flight, which was then handled poorly. Tentative code changes sitting on this branch will be tested soon (https://github.com/jhu-digital-manuscripts/mirador/tree/search-dropdown-bugfixes)

jabrah commented 4 years ago

Test instance deployed for DLMM: https://rosetest.library.jhu.edu/dlmm

markpatton commented 3 years ago

Also seems like links on portal like https://dlmm.library.jhu.edu/viewer/#rose do not correctly populate the collection dropdown.

jabrah commented 3 years ago

Rosetest updated, hopefully addresses your comment about /viewer#rose not loading correctly

markpatton commented 3 years ago

Looks good now!