Applications dialog boxes trigger on Value Edits rather than the RETURN Button

jhu-dvrk / dvrk-ros

daVinci Research Kit ROS stack. See dVRK wiki to get started: https://github.com/jhu-dvrk/sawIntuitiveResearchKit/wiki

https://github.com/jhu-dvrk/sawIntuitiveResearchKit/wiki

Other

100 stars 80 forks source link

Applications dialog boxes trigger on Value Edits rather than the RETURN Button #30

Closed adnanmunawar closed 5 years ago

adnanmunawar commented 5 years ago

When controlling the dVRK Manipulators using the QT GUI (mostly for debugging purposes), the control dialog boxes aren't the most convenient. They callback the underlying joint control function as soon as the user changes the value in the dialog box rather than waiting for the user to press ENTER.

adeguet1 commented 5 years ago

Could you specify which dialog box you're referring to? IO/PID/Arm/Console?

adnanmunawar commented 5 years ago

I am specifically talking about the PID console tab (Position Targets, P, I and D gains which are editable fields) but it might apply to other consoles tabs as well.

adeguet1 commented 5 years ago

Can you pull the latest devel for cisst and sawRobotIO to test my changes:

If this works for you, I'll also patch the "scale" for teleop in sawIntuitiveResearchKit.

adnanmunawar commented 5 years ago

Tested. This works as intended. Thanks