Open TangRunze opened 7 years ago
Do we want to have an experiment which shows the subgroup inference?
The presentation and writing skills need to be radically improved. The authors should carefully proof-read the material before submission and have a sanity check if the current manuscript conforms to the journals' standard. Several things come to mind as potential remedies. Consider your audience. Publications from this journal are read by researchers with diverse backgrounds including machine-learning, neuroscience, psychology, psychiatry, statistics, engineering and physics. Thus, in order to maximise your impact you really need to write things in a simple manner whenever possible.
Satisfy the readers' expectation. As a reader I was getting really irritated with some sections because the ground would be prepared for one point and then something completely different would be stated next.
Your figure captions need to clearly define all the components of your plot before you proceed to comment on the most striking results.
I can change this if necessary.
Typos/Grammar. You need to make sure that your text is free from typos.
Why not a sum over i? Or maybe we just change all < · > notation into x^{\top} y?
I think if we change x, y to xi, xj it might be a little bit confusing, since in the paper xi is actually a vector, but here it would be a scalar.
No, it is a number.
I changed some of them, but if there is a parathesis after it, using \phantom{\top} will have an extra space, which doesn't look nice.
Note that this list of examples is not exhaustive, there are plenty of other instances when things are not defined but are used or it is assumed that the reader knows your notation very well.
Citation. Please pay attention how you are citing.
\citet or \citep?
Notation. Please do not abuse statistical notation! Capital Roman letters indicate random quantities and small Roman letters indicate their realisations.
Objectiveness. Please do not misuse adjectives when you are comparing things.
Structure. Please also consider re-structuring your work.
Again, there are other places where you could have structured things in a more reader-friendly way. For example, look at some NeuroImage papers and see how they structure the simulation methods and results. You can do something like that too. Also, NeuroImage allows only sections and subsections, so I really think that you should use these wisely.
My general impression of this work is that it is very sloppy. There is some interesting material, but it will take serious efforts and work to get this into a good shape. I personally expect every NeuroImage paper to be self-contained. If you are using some method then this needs to be defined. Although I do not expect this to appear in the main text, all background material should be easily accessible and contained in either the appendix or in the supplementary material of this manuscript. This should be obviously summarised in your own words and with your own notation.
No, it is a scalar.
Because tau_i is the block membership.
What does "massaged into" mean?
That is true. But we do have a sentence discuss that. What does the last sentence mean?
Maybe put it into the section finite sample simulation? Discuss the block sizes
I don't get this.
We don't need to?
Section 6.1?
We said it is Figure 4?
Should we just say sample mean \pm 1.96*std/sqrt(n)?
I didn't get this.
Actual dimension: we don't know. Estimated dimension: 11 which is mentioned.
[1] Mikail Rubinov and Olaf Sporns. Complex network measures of brain connectivity: uses and interpretations. Neuroimage, 52(3):1059-1069, 2010. [2] Christophe Ambroise and Catherine Matias. New consistent and asymptotically normal parameter estimates for random-graph mixture models. Journal of the Royal Statistical Society: Series B (Statistical Methodology), 74(1):3-35, 2012. [3] Patrick J Wolfe and Sofia C Olhede. Nonparametric graphon estimation. arXiv preprint arXiv:1309.5936, 2013. [4] David S Choi, Patrick J Wolfe, and Edoardo M Airoldi. Stochastic blockmodels with a growing number of classes. Biometrika, page asr053, 2012. [5] Franck Picard, Vincent Miele, Jean-Jacques Daudin, Ludovic Cottret, and St ́ephane Robin. Deciphering the connectivity structure of biological networks using mixnet. BMC bioinformatics, 10(6):1, 2009. [6] Hugo Zanghi, Christophe Ambroise, and Vincent Miele. Fast online graph clustering via erd ̋os-r ́enyi mixture. Pattern Recognition, 41(12):3592-3599, 2008. [7] Hugo Zanghi, Stevenn Volant, and Christophe Ambroise. Clustering based on random graph model embedding vertex features. Pattern Recognition Letters, 31(9):830-836, 2010. [8] Dragana M Pavlovic, Petra E V ́ertes, Edward T Bullmore, William R Schafer, and Thomas E Nichols. Stochastic blockmodeling of the modules and core of the caenorhabditis elegans connectome. PloS one, 9(7):e97584, 2014. [9] J-J Daudin, Franck Picard, and St ́ephane Robin. A mixture model for random graphs. Statistics and computing, 18(2):173-183, 2008. [10] Avanti Athreya, Carey E Priebe, Minh Tang, Vince Lyzinski, David J Marchette, and Daniel L Sussman. A limit theorem for scaled eigenvectors of random dot product graphs. Sankhya A, 78(1):1-18, 2016. [11] Sourav Chatterjee et al. Matrix estimation by universal singular value thresholding. The Annals of Statistics, 43(1):177-214, 2015.
https://github.com/jhu-graphstat/LLG/blob/master/plos-latex/eigenvector.pdf https://github.com/jhu-graphstat/LLG/blob/master/plos-latex/eigenvector1.pdf
https://github.com/jhu-graphstat/LLG/blob/master/Draft/eigenvector_scatter.pdf I prefer the original 70x12 plot.
i don't like that either. i like the heatmap, and/or the image of the brain.
On Wed, Jan 11, 2017 at 2:23 PM, Runze Tang notifications@github.com wrote:
- Scatter plot of the eigenvectors based on the first two dimensions.
https://github.com/jhu-graphstat/LLG/blob/master/ Draft/eigenvector_scatter.pdf I prefer the original 70x12 plot.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jhu-graphstat/LLG/issues/14#issuecomment-271967862, or mute the thread https://github.com/notifications/unsubscribe-auth/AACjcg9GY_G61RUgamxX45DF6jjG2lAJks5rRSw1gaJpZM4La85t .
-- the glass is all full: half water, half air. neurodata.io, jovo calendar https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York starting in 2017, i will be responding to emails approximately weekly, so that i can focus more on the people around me. thank you for your understanding.
I think I don't really like either option too much. @TangRunze did you try resorting the rows of the 70x12 plot to illuminate more structure?
@dpmcsuss I tried the hclust, but I don't see any specific structure except for the left & right hemispheres. https://github.com/jhu-graphstat/LLG/blob/master/Draft/Dendrogram.pdf
Can you show the heat map with the dendrogram ordering?
https://github.com/jhu-graphstat/LLG/blob/master/Draft/eigenvector_reorder.pdf And the order is: 35 31 2 9 30 4 24 18 32 23 25 15 34 27 13 20 19 21 28 29 3 5 16 8 10 7 17 11 1 26 6 14 12 22 41 43 57 47 49 33 68 42 69 55 45 51 50 56 63 48 62 53 59 38 64 39 40 54 66 46 61 36 52 37 70 67 58 60 44 65
Yeah, to me that still looks like a jumble (except for left right hemispheres in the second evector). I'm down to include something like this if we have something meaning to say about it.
Aside, have you tried the same plot with the rescaled evectors?
For the rescaled evectors, Dendrogram:
https://github.com/jhu-graphstat/LLG/blob/master/Draft/Dendrogram_rescaled.png
Heatmap:
https://github.com/jhu-graphstat/LLG/blob/master/Draft/eigenvector_reorder_rescaled.pdf
The image of the brain with the 2nd dimension of the latent positions:
https://github.com/jhu-graphstat/LLG/blob/master/Code/MATLAB/BrainVis/brain.png
I will update it with the new tool when Greg gets back go me.
hm, that one is relatively more clear than the others. though with @gkiar tool, i think it will be way better!
On Mon, Jan 16, 2017 at 1:54 PM, Runze Tang notifications@github.com wrote:
The image of the brain with the 2nd dimension of the latent positions:
https://github.com/jhu-graphstat/LLG/blob/master/ Code/MATLAB/BrainVis/brain.png I will update it with the new tool when Greg gets back go me.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jhu-graphstat/LLG/issues/14#issuecomment-272938192, or mute the thread https://github.com/notifications/unsubscribe-auth/AACjchDoZEBcmyz8HEm_p3OqdxfNo4wOks5rS7zhgaJpZM4La85t .
-- the glass is all full: half water, half air. neurodata.io, jovo calendar https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York starting in 2017, i will be responding to emails approximately weekly, so that i can focus more on the people around me. thank you for your understanding.
Can't wait to use the tool!
@jovo @TangRunze It's not a "tool" per-se, but rather one of our new QC figures enables us to do this type of plot more easily. @TangRunze if you can provide me with a vector of relative intensities for each region I can put it on the stack for this week. (i.e. if desikan atlas, then a 70x1
vector in order of region number, such that the first element corresponds to node 1, etc.)
@gkiar Thank you very much! It will be great if it is easy for me to run.
Here is the csv file containing the 70x1 vector. eigenvector_dim2.csv.zip
Yup - once I prototype exactly what I perceive you to need I'll give you a command-line script and description of how to run it :unicorn:
& Thanks for the vector!
Awesome! And probably we also want to update our previous figure (https://github.com/jhu-graphstat/LLG/blob/master/plos-latex/Diff_Between_desikan.png) with the lines between regions to make it look better! Thanks!
Addressed this in the following PR: https://github.com/jhu-graphstat/LLG/pull/15 Shoutout to @vikramc1 for doing everything :)
Thank you both @gkiar @vikramc1 ! The figures look great! We will think about it and probably will come back to you later.
On Jan 23, 2017, at 12:11, Greg Kiar notifications@github.com wrote:
Addressed this in the following PR: #15 https://github.com/jhu-graphstat/LLG/pull/15 Shoutout to @vikramc1 https://github.com/vikramc1 for doing everything :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhu-graphstat/LLG/issues/14#issuecomment-274551100, or mute the thread https://github.com/notifications/unsubscribe-auth/AFM77QiZgNd5r7zZBZgZVg3qiE4NMwnuks5rVN8ngaJpZM4La85t.
Reviewer 1