Replace absolute URL with relative when initializing Mirador - Githubissues

jhu-idc / idc-isle-dc

Islandora Digital Collections (IDC) development environment

MIT License

2 stars 6 forks source link

Replace absolute URL with relative when initializing Mirador #270

Closed jabrah closed 2 years ago

jabrah commented 2 years ago

Resolves https://github.com/jhu-idc/iDC-general/issues/440

Paged Content currently likely fails to render at the moment, as Mirador is configured to point to an absolute URL with the islandora-idc.traefik.me host in order to retrieve the IIIF manifest . This change makes the manifest URLs relative - Mirador will now look at /node/<nodeId>/manifest.

This only effects Paged Content items

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (9f2db355230458312fde5269f0f6651a726e5435) and PR branch fix-mirador-bug (4afd2a3184beadadb5df5ba904ef4a9161c3cf27):

diff --git a/deps.9f2db355230458312fde5269f0f6651a726e5435 b/deps.pr-270.4afd2a3184beadadb5df5ba904ef4a9161c3cf27
index b09f50e..a6c3fb2 100644
--- a/deps.9f2db355230458312fde5269f0f6651a726e5435
+++ b/deps.pr-270.4afd2a3184beadadb5df5ba904ef4a9161c3cf27
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main 280eaef   
+jhu-idc/idc-ui-theme                                      dev-main 4474020   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 4966136   
 jhu-idc/idc_ui_module                                     dev-main 740a097

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (9f2db355230458312fde5269f0f6651a726e5435) and PR branch fix-mirador-bug (597499bba8c44117abb510f9b276d287ac7afd28):

diff --git a/deps.9f2db355230458312fde5269f0f6651a726e5435 b/deps.pr-270.597499bba8c44117abb510f9b276d287ac7afd28
index 7472343..17aa1f6 100644
--- a/deps.9f2db355230458312fde5269f0f6651a726e5435
+++ b/deps.pr-270.597499bba8c44117abb510f9b276d287ac7afd28
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main 280eaef   
+jhu-idc/idc-ui-theme                                      dev-main 4474020   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 33c3b31   
 jhu-idc/idc_ui_module                                     dev-main a5b663a

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (42317b26fea7ca55a6306cfc742baa8366e1807f) and PR branch fix-mirador-bug (4afd2a3184beadadb5df5ba904ef4a9161c3cf27):

diff --git a/deps.42317b26fea7ca55a6306cfc742baa8366e1807f b/deps.pr-270.4afd2a3184beadadb5df5ba904ef4a9161c3cf27
index 7472343..17aa1f6 100644
--- a/deps.42317b26fea7ca55a6306cfc742baa8366e1807f
+++ b/deps.pr-270.4afd2a3184beadadb5df5ba904ef4a9161c3cf27
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main 280eaef   
+jhu-idc/idc-ui-theme                                      dev-main 4474020   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 33c3b31   
 jhu-idc/idc_ui_module                                     dev-main a5b663a

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (42317b26fea7ca55a6306cfc742baa8366e1807f) and PR branch fix-mirador-bug (5cb707ecdff4d541fdd1b216afa3b3fe00962db2):

diff --git a/deps.42317b26fea7ca55a6306cfc742baa8366e1807f b/deps.pr-270.5cb707ecdff4d541fdd1b216afa3b3fe00962db2
index 7472343..17aa1f6 100644
--- a/deps.42317b26fea7ca55a6306cfc742baa8366e1807f
+++ b/deps.pr-270.5cb707ecdff4d541fdd1b216afa3b3fe00962db2
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main 280eaef   
+jhu-idc/idc-ui-theme                                      dev-main 4474020   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 33c3b31   
 jhu-idc/idc_ui_module                                     dev-main a5b663a

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (42317b26fea7ca55a6306cfc742baa8366e1807f) and PR branch fix-mirador-bug (29bf46905b9771a2f824b94b882fecdebb6edb58):

diff --git a/deps.42317b26fea7ca55a6306cfc742baa8366e1807f b/deps.pr-270.29bf46905b9771a2f824b94b882fecdebb6edb58
index 7472343..17aa1f6 100644
--- a/deps.42317b26fea7ca55a6306cfc742baa8366e1807f
+++ b/deps.pr-270.29bf46905b9771a2f824b94b882fecdebb6edb58
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main 280eaef   
+jhu-idc/idc-ui-theme                                      dev-main 4474020   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 33c3b31   
 jhu-idc/idc_ui_module                                     dev-main a5b663a