jhu-idc / idc-isle-dc

Islandora Digital Collections (IDC) development environment
MIT License
2 stars 6 forks source link

Update to Drupal 9.3.0 #284

Closed little9 closed 2 years ago

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (f2d5e7dde566ba153be831e804a510c593a920f3) and PR branch update-drupal-9-3-0 (9443140af034fc4df848b062cf96ec12f506d4fc):

diff --git a/deps.f2d5e7dde566ba153be831e804a510c593a920f3 b/deps.pr-284.9443140af034fc4df848b062cf96ec12f506d4fc
index 2c086ca..a59078d 100644
--- a/deps.f2d5e7dde566ba153be831e804a510c593a920f3
+++ b/deps.pr-284.9443140af034fc4df848b062cf96ec12f506d4fc
@@ -12,7 +12,7 @@ composer/composer                                         2.1.6
 composer/installers                                       v1.11.0            
 composer/metadata-minifier                                1.0.0              
 composer/package-versions-deprecated                      1.11.99.3          
-composer/semver                                           3.2.5              
+composer/semver                                           3.2.6              
 composer/spdx-licenses                                    1.5.5              
 composer/xdebug-handler                                   2.0.2              
 consolidation/annotated-command                           4.2.4              
@@ -29,7 +29,7 @@ cweagans/composer-patches                                 1.7.1
 dflydev/dot-access-configuration                          v1.0.3             
 dflydev/dot-access-data                                   v1.1.0             
 dflydev/placeholder-resolver                              v1.0.2             
-doctrine/annotations                                      1.13.1             
+doctrine/annotations                                      1.13.2             
 doctrine/cache                                            1.12.1             
 doctrine/collections                                      1.6.8              
 doctrine/common                                           2.13.3             
@@ -57,11 +57,11 @@ drupal/contact_emails                                     1.20.0
 drupal/contact_storage                                    1.1.0              
 drupal/content_browser                                    1.0.0              
 drupal/context                                            4.1.0              
-drupal/core                                               9.2.10             
+drupal/core                                               9.3.0              
 drupal/core-composer-scaffold                             9.2.4              
 drupal/core-dev                                           9.2.4              
 drupal/core-project-message                               9.2.4              
-drupal/core-recommended                                   9.2.10             
+drupal/core-recommended                                   9.3.0              
 drupal/core-vendor-hardening                              9.2.4              
 drupal/csv_serialization                                  2.0.0              
 drupal/devel                                              4.1.1              
@@ -112,19 +112,19 @@ drupal/workbench                                          1.3.0
 drupal/workbench_access                                   1.0.0-beta4        
 drush/drush                                               10.6.0             
 easyrdf/easyrdf                                           1.1.1              
-egulias/email-validator                                   2.1.25             
+egulias/email-validator                                   3.1.2              
 enlightn/security-checker                                 v1.9.0             
 fabpot/goutte                                             v3.3.1             
 fileeye/mimemap                                           1.1.5              
 firebase/php-jwt                                          v5.4.0             
-friends-of-behat/mink-browserkit-driver                   v1.5.0             
+friends-of-behat/mink-browserkit-driver                   v1.6.1             
 gettext/gettext                                           v4.8.5             
 gettext/languages                                         2.8.1              
 grasmash/expander                                         1.0.0              
 grasmash/yaml-expander                                    1.4.0              
 guzzlehttp/guzzle                                         6.5.5              
-guzzlehttp/promises                                       1.4.1              
-guzzlehttp/psr7                                           1.8.2              
+guzzlehttp/promises                                       1.5.1              
+guzzlehttp/psr7                                           1.8.3              
 instaclick/php-webdriver                                  1.4.9              
 islandora-rdm/islandora_fits                              dev-master b9d0415 
 islandora/carapace                                        dev-8.x-3.x 30e6619
@@ -145,11 +145,10 @@ jhu-idc/migrate_file                                      dev-8.x-1.x 19d0ea1
 jhu-idc/reference_value_pair                              dev-main ee0bb99   
 jhu_idc/idc_migration                                     v2.0.1             
 justinrainbow/json-schema                                 5.2.11             
-laminas/laminas-diactoros                                 2.6.0              
-laminas/laminas-escaper                                   2.7.0              
-laminas/laminas-feed                                      2.14.1             
-laminas/laminas-stdlib                                    3.3.1              
-laminas/laminas-zendframework-bridge                      1.2.0              
+laminas/laminas-diactoros                                 2.8.0              
+laminas/laminas-escaper                                   2.9.0              
+laminas/laminas-feed                                      2.15.0             
+laminas/laminas-stdlib                                    3.6.1              
 league/container                                          2.5.0              
 league/csv                                                9.7.1              
 league/flysystem                                          1.1.5              
@@ -157,7 +156,7 @@ league/flysystem-replicate-adapter                        1.0.1
 league/mime-type-detection                                1.7.0              
 lsolesen/pel                                              0.9.10             
 maennchen/zipstream-php                                   2.1.0              
-masterminds/html5                                         2.7.4              
+masterminds/html5                                         2.7.5              
 mglaman/drupal-check                                      1.1.10             
 mglaman/phpstan-drupal                                    0.12.12            
 mikey179/vfsstream                                        v1.6.10            
@@ -174,7 +173,7 @@ nette/utils                                               v3.2.3
 nikic/php-parser                                          v4.13.2            
 pear/archive_tar                                          1.4.14             
 pear/console_getopt                                       v1.4.3             
-pear/pear-core-minimal                                    v1.10.10           
+pear/pear-core-minimal                                    v1.10.11           
 pear/pear_exception                                       v1.0.2             
 phar-io/manifest                                          2.0.3              
 phar-io/version                                           3.1.0              
@@ -185,7 +184,7 @@ phpdocumentor/type-resolver                               1.5.1
 phpfastcache/riak-client                                  3.4.3              
 phpmailer/phpmailer                                       v6.5.1             
 phpoption/phpoption                                       1.7.5              
-phpspec/prophecy                                          1.14.0             
+phpspec/prophecy                                          v1.15.0            
 phpspec/prophecy-phpunit                                  v2.0.1             
 phpstan/phpstan                                           0.12.96            
 phpstan/phpstan-deprecation-rules                         0.12.6             
@@ -267,61 +266,61 @@ squizlabs/php_codesniffer                                 3.6.0
 stack/builder                                             v1.0.6             
 stecman/symfony-console-completion                        0.11.0             
 stomp-php/stomp-php                                       4.6.1              
-symfony-cmf/routing                                       2.3.3              
+symfony-cmf/routing                                       2.3.4              
 symfony/browser-kit                                       v4.4.27            
 symfony/cache                                             v5.3.4             
 symfony/cache-contracts                                   v2.5.0             
 symfony/config                                            v4.4.27            
-symfony/console                                           v4.4.25            
+symfony/console                                           v4.4.34            
 symfony/css-selector                                      v4.4.27            
-symfony/debug                                             v4.4.25            
-symfony/dependency-injection                              v4.4.25            
-symfony/deprecation-contracts                             v2.4.0             
+symfony/debug                                             v4.4.31            
+symfony/dependency-injection                              v4.4.34            
+symfony/deprecation-contracts                             v2.5.0             
 symfony/dom-crawler                                       v4.4.30            
-symfony/error-handler                                     v4.4.25            
-symfony/event-dispatcher                                  v4.4.25            
-symfony/event-dispatcher-contracts                        v1.1.9             
+symfony/error-handler                                     v4.4.34            
+symfony/event-dispatcher                                  v4.4.34            
+symfony/event-dispatcher-contracts                        v1.1.11            
 symfony/filesystem                                        v4.4.27            
 symfony/finder                                            v4.4.30            
 symfony/framework-bundle                                  v4.4.27            
-symfony/http-client-contracts                             v2.4.0             
-symfony/http-foundation                                   v4.4.25            
-symfony/http-kernel                                       v4.4.25            
+symfony/http-client-contracts                             v2.5.0             
+symfony/http-foundation                                   v4.4.34            
+symfony/http-kernel                                       v4.4.35            
 symfony/lock                                              v4.4.27            
-symfony/mime                                              v5.3.0             
+symfony/mime                                              v5.4.0             
 symfony/phpunit-bridge                                    v5.3.4             
 symfony/polyfill-ctype                                    v1.23.0            
 symfony/polyfill-iconv                                    v1.23.0            
 symfony/polyfill-intl-grapheme                            v1.23.1            
 symfony/polyfill-intl-idn                                 v1.23.0            
 symfony/polyfill-intl-normalizer                          v1.23.0            
-symfony/polyfill-mbstring                                 v1.23.0            
+symfony/polyfill-mbstring                                 v1.23.1            
 symfony/polyfill-php56                                    v1.20.0            
 symfony/polyfill-php72                                    v1.23.0            
 symfony/polyfill-php73                                    v1.23.0            
-symfony/polyfill-php80                                    v1.23.0            
+symfony/polyfill-php80                                    v1.23.1            
 symfony/polyfill-php81                                    v1.23.0            
-symfony/process                                           v4.4.25            
+symfony/process                                           v4.4.35            
 symfony/property-access                                   v5.4.0             
 symfony/property-info                                     v5.4.0             
-symfony/psr-http-message-bridge                           v2.1.0             
-symfony/routing                                           v4.4.25            
+symfony/psr-http-message-bridge                           v2.1.2             
+symfony/routing                                           v4.4.34            
 symfony/security                                          v4.4.29            
 symfony/serializer                                        v4.4.35            
-symfony/service-contracts                                 v2.4.0             
+symfony/service-contracts                                 v2.5.0             
 symfony/string                                            v5.4.0             
-symfony/translation                                       v4.4.25            
-symfony/translation-contracts                             v2.4.0             
-symfony/validator                                         v4.4.25            
-symfony/var-dumper                                        v5.3.0             
+symfony/translation                                       v4.4.34            
+symfony/translation-contracts                             v2.5.0             
+symfony/validator                                         v4.4.35            
+symfony/var-dumper                                        v5.4.0             
 symfony/var-exporter                                      v5.3.4             
-symfony/yaml                                              v4.4.25            
+symfony/yaml                                              v4.4.34            
 theseer/tokenizer                                         1.2.1              
 twig/extensions                                           v1.5.4             
-twig/twig                                                 v2.14.6            
+twig/twig                                                 v2.14.7            
 twistor/flysystem-stream-wrapper                          v1.0.9             
 twistor/stream-util                                       v1.0.1             
-typo3/phar-stream-wrapper                                 v3.1.6             
+typo3/phar-stream-wrapper                                 v3.1.7             
 vlucas/phpdotenv                                          v4.2.0             
 webflo/drupal-finder                                      1.2.2              
 webmozart/assert                                          1.10.0             
bseeger commented 2 years ago

After I do a make reset on this branch, I get an empty webpage with The website encountered an unexpected error. Please try again later on it.

9.3 has a few deprecations that might be behaving badly. Or rather, the deprecations are fine, but there is a case where if a null is passed in to something, it starts to fail now. I suspect we have a few spots where that needs to be handled.

I was seeing this error in the drupal log:

drupal_1      | 2021/12/20 19:15:48 [error] 1883#1883: *10 FastCGI sent in stderr: "PHP message: TypeError: Argument 2 passed to Drupal\Core\Extension\ExtensionPathResolver::getPath() must be of the type string, null given, called in /var/www/drupal/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php on line 123 in /var/www/drupal/web/core/lib/Drupal/Core/Extension/ExtensionPathResolver.php on line 84 #0 /var/www/drupal/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php(123): Drupal\Core\Extension\ExtensionPathResolver->getPath('theme', NULL)

And then I found this: https://www.drupal.org/project/drupal/issues/3254245

But I'm not sure how applicable that is.

Something is definitely not playing nicely in the update.