github-actions[bot]
commented
2 years ago Dependency diff between development base branch development (36e613f42603869952ad2f6d3275195540fdf807) and PR branch global-search-fix-boolean-ops (c0fd64eb57f03699d8f56045e64b2c671029985e):
diff --git a/deps.36e613f42603869952ad2f6d3275195540fdf807 b/deps.pr-290.c0fd64eb57f03699d8f56045e64b2c671029985e
index 2c086ca..73121b1 100644
--- a/deps.36e613f42603869952ad2f6d3275195540fdf807
+++ b/deps.pr-290.c0fd64eb57f03699d8f56045e64b2c671029985e
@@ -135,7 +135,7 @@ islandora/jsonld dev-8.x-1.x dfd99c4
islandora/openseadragon dev-8.x-1.x 5f847e5
jean85/pretty-package-versions 1.6.0
jhu-idc/controlled_access_terms dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme dev-main 0c32304
+jhu-idc/idc-ui-theme dev-main 278d742
jhu-idc/idc_defaults dev-main cb033a6
jhu-idc/idc_export dev-main 33c3b31
jhu-idc/idc_ui_module dev-main c353d1e
?queryURL parameter while initializing the search UI, since it's not necessary and causing bugs. (Tests will be added toidc-isle-dcfor global search.)Comments noted in the old
#parseSolrQueryfunction don't apply to the query that is parsed. This function seems to have been originally intended to parse the query that is passed to Solr, although its ultimate use was to parse the query parameter of the search page, which doesn't require the same level of parsing.Use entered search terms are now surrounded by parentheses in order to apply as expected along side page level filters, such as the node filter on a collection details page. Order-of-operations could get weird without the parentheses leading to weird search behaviors. This will lead to uglier Solr queries, such as
?query="plastic material"~10 OR (test) NOT (item AND rendering)(first example below). Note the middle keyword: test term is just the word test in parentheses. While this doesn't look great in the Solr query, it functions fine and requires zero logic to decide when to apply the parentheses.Some examples of searches covered by these changes: