search

jhu-idc / idc-isle-dc

Islandora Digital Collections (IDC) development environment
MIT License
2 stars 6 forks source link

Allow Drupal admin name to be configured with an env variable #295

Closed little9 closed 2 years ago

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

little9 commented 2 years ago

@bseeger It doesn't like I'm able to access the env vars from the testcafe tests. I believe if I leave them hardcoded it should pass because of the defaults. I may try that if I can't figure out why they aren't being passed in. Do you notice any gaps where the env vars may have dropped off?

I wasn't able to use the ${DRUPAL_DEFAULT_ACCOUNT_NAME:admin} syntax for setting a default in the yml files.

little9 commented 2 years ago

...or maybe I just forgot to add the password to the .env file.

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

bseeger commented 2 years ago

This is much, much closer. The password is set fine, but the username doesn't get changed. I realized it's because the database needs to be specified in the command as well. Then it changes.

drush sql-query 'use drupal_default; UPDATE users_field_data SET name='\''joe'\'' WHERE uid=1'

(using DRUPAL_DEFAULT_DB_NAME)

I'm putting this here, but really this change is needed in idc-isle-buildkit.

little9 commented 2 years ago

@bseeger I updated this with an updated drupal image containing those changes.

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch