Fix media rendering on item detail page

jhu-idc / idc-isle-dc

Islandora Digital Collections (IDC) development environment

MIT License

2 stars 6 forks source link

Fix media rendering on item detail page #300

Closed jaredgalanis closed 2 years ago

jaredgalanis commented 2 years ago

Addresses: https://github.com/jhu-idc/iDC-general/issues/456

Turns off caching for the preprocess media hook to ensure the hook is run each page load that invokes the media template so that the necessary variables can be setup for the template logic
Template logic conditionally displays the media in various formats for an islandora object, media page and taxonomy page

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (5ec116bd18cec74c14c2877e6319d3a52fc725a3) and PR branch media-rendering (4adf09df0bb37a9d7e23b2c7c0e7ac69b9769a5f):

diff --git a/deps.5ec116bd18cec74c14c2877e6319d3a52fc725a3 b/deps.pr-300.4adf09df0bb37a9d7e23b2c7c0e7ac69b9769a5f
index d3eb4d9..50e4493 100644
--- a/deps.5ec116bd18cec74c14c2877e6319d3a52fc725a3
+++ b/deps.pr-300.4adf09df0bb37a9d7e23b2c7c0e7ac69b9769a5f
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main bd303f8   
+jhu-idc/idc-ui-theme                                      dev-main 73aa732   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 33c3b31   
 jhu-idc/idc_ui_module                                     dev-main c353d1e

jabrah commented 2 years ago

The media template misbehaves on taxonomy pages, but that can be fixed later (should have been caught earlier in the PR to the theme) https://islandora-idc.traefik.me/taxonomy/term/50

github-actions[bot] commented 2 years ago

Dependency diff between development base branch development (5ec116bd18cec74c14c2877e6319d3a52fc725a3) and PR branch media-rendering (adca6d9c4a46d9c2e71175f2c3d55e94402b2009):

diff --git a/deps.5ec116bd18cec74c14c2877e6319d3a52fc725a3 b/deps.pr-300.adca6d9c4a46d9c2e71175f2c3d55e94402b2009
index d3eb4d9..3cb8ec1 100644
--- a/deps.5ec116bd18cec74c14c2877e6319d3a52fc725a3
+++ b/deps.pr-300.adca6d9c4a46d9c2e71175f2c3d55e94402b2009
@@ -135,7 +135,7 @@ islandora/jsonld                                          dev-8.x-1.x dfd99c4
 islandora/openseadragon                                   dev-8.x-1.x 5f847e5
 jean85/pretty-package-versions                            1.6.0              
 jhu-idc/controlled_access_terms                           dev-8.x-1.x 7a03834
-jhu-idc/idc-ui-theme                                      dev-main bd303f8   
+jhu-idc/idc-ui-theme                                      dev-main 245ef90   
 jhu-idc/idc_defaults                                      dev-main cb033a6   
 jhu-idc/idc_export                                        dev-main 33c3b31   
 jhu-idc/idc_ui_module                                     dev-main c353d1e