search

jhu-idc / idc-isle-dc

Islandora Digital Collections (IDC) development environment
MIT License
2 stars 6 forks source link

Remove log in link for users who are not signed in and create alias f… #327

Open jatjhu opened 2 years ago

jatjhu commented 2 years ago

…or jhuid

github-actions[bot] commented 2 years ago

This PR has no dependency differences with the base branch

DonRichards commented 1 year ago

@jatjhu How do I test this?

jatjhu commented 1 year ago

@DonRichards pull this down and go to the site as an anonymous user. The login link should not appear. If you got to /jhlogin, it should start the saml sign in process.

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=327&src=https%3A%2F%2Fgithub.com%2Fjhu-idc%2Fidc-isle-dc)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

github-actions[bot] commented 1 year ago

This PR has no dependency differences with the base branch

github-actions[bot] commented 1 year ago

This PR has no dependency differences with the base branch

DonRichards commented 1 year ago

@jatjhu I tried this a few times and couldn't get it to work. Is there anything special about when & when it would work? Is it supposed to work on our local environment or just when it's deployed with JHED auth enabled?