search

jhu-lcsr-forks / rtt_ros_integration

Orocos-ROS integration libraries and tools
1 stars 2 forks source link

rtt_roscomm: Paths of the rtt_roscomm_pkg_template folder differs in devel-space and install-space #20

Closed meyerj closed 10 years ago

meyerj commented 10 years ago

Install-space deployments of package rtt_roscomm are currently broken as ${rtt_roscomm_DIR} resolves to share/rtt_roscomm/cmake in GenerateRTTROSCommPackage.cmake. The template files should not be installed to the subfolder cmake in order to keep the path consistent between package source, devel-space and install-space.

jbohren commented 10 years ago

I'm going to add some buildsystem unit tests to make sure changes like these don't break any of the build patterns. Once I do that, we can run this against them to make sure everything is still good.

meyerj commented 10 years ago

Okay, whatever you think. Automatic tests are indeed indispensable. On the other hand I am not sure if we should wait until all tests have been setup before the first release of the toolchain and rtt_ros_integration in hydro (probably without the new or untested features).

In this specific case I tested the patch with

  1. catkin_make_isolated --install in a single workspace together with orocos_toolchain, rtt_ros_comm, rtt_common_msgs,...
  2. catkin_make in a separate workspace building on top of a standalone installation of orocos_toolchain (sourcing devel/setup.bash)
  3. catkin_make install in a separate workspace as above, but with additional installation (sourcing install/setup.bash)

In all three cases I could create new rtt message packages using the create_rtt_msg script and typekits have been built successfully. Without this patch building message packages with an installed version of rtt_roscomm is currently broken (case 1. and 3.)!

jbohren commented 10 years ago

Don't worry, these low-level tests have priority. I plan in putting them together today. At that point I'll figure out this PR as well as my "repair" branch.