search

jhu-lcsr-forks / rtt_ros_integration

Orocos-ROS integration libraries and tools
1 stars 2 forks source link

Use cmake macros instead of functions in GenerateRTTROSCommPackage.cmake.em #7

Closed meyerj closed 11 years ago

meyerj commented 11 years ago

orocos_generate_package() only considers the current scope for targets to be added to the pkg-config file. With the current version using cmake functions the resulting .pc files do not contain the generated libraries, which results in linker errors in dependent packages.

meyerj commented 11 years ago

I just noticed that if ros_generate_rtt_typekit and ros_generate_rtt_service_proxies are macros they might influence other targets following the macro call within the same scope (include directories, CMAKE_BUILD_TYPE, etc.). Does this cause any problems?

jbohren commented 11 years ago

I just noticed that if ros_generate_rtt_typekit and ros_generate_rtt_service_proxies are macros they might influence other targets following the macro call within the same scope (include directories, CMAKE_BUILD_TYPE, etc.). Does this cause any problems?

I don't think that's too big of a deal. Also, if we're concerned about it, we could jut set the individual target properties for the targets created by these macros.