search

jhu-lcsr / handeye_calib_camodocal

Easy to use and accurate hand eye calibration which has been working reliably for years (2016-present) with kinect, kinectv2, rgbd cameras, optical trackers, and several robots including the ur5 and kuka iiwa.
BSD 2-Clause "Simplified" License
543 stars 178 forks source link

more solver summary data #14

Closed ahundt closed 6 years ago

ahundt commented 6 years ago

@cthorey implemented some additional summary information on a fork. This looks like it would be useful to have! Does it work for you and are you willing for it to be merged?

cthorey commented 6 years ago

Hi,

This PR is duplicated with the two previous one. May be we can close the two others and focus on this one.

  1. Make sure resultAffine is returned by estimatedHandeye.
  2. This param was actually setup twice , that s why I removed one of them.
  3. I set a new parameter to allow the user to tag/ or not the info relative to the solver summary along witht he transform 
    <arg name="add_solver_summary"     default="false" />
  4. I did as you recommended, using function overloading to make tagging the summary optional and select which one to use based on the add_solver_summary param above for the ROS node.
  5. Correct the spelling error
  6. I did not really know what to use for the formatting, so I just format all files with clang-format which provide a consistent formatting across the files. We can specify the conf file if you have any requirement :)
ahundt commented 6 years ago

I'm really sorry to ask for more steps, I know it is a pain to do, but can we do one PR with minimal functionality changes and one with formatting? I can't review the actual changes easily because everything has moved around.

Also I'm cool with that format but I would prefer 4 spaces for indentation.

cthorey commented 6 years ago

Yes, make sense. Sorry for that. This PR now contains only the changes.

ahundt commented 6 years ago

LGTM, thanks for this really really nice update!