Feedback on Iteration 3

[darvishdarab]

Iteration 3 (83/90 Points)

Retrospective (5/5 points)

- Good

Software Requirement Specification (5/5 points)

• All sections are up-to-date
  • Problem Statement
  • Proposed Solution
  • Potential Clients
  • Must Haves
  • Nice to Haves
  • Architecture & Technologies

Feedback

• Good

Class Diagram (4/5 points)

Feedback

• I am assuming that your UML did not change from it2, but reminder to still upload a UML diagram for it3, even if it is the exact same copy. Same for SRS.

Git Activities (10/10 points)

• All members are contributing - have been committing/pushing frequently - using branches and/or pull requests - github issues

Feedback

• Good
• Remember to check your issues tab, some of the opened issues seems to be outdated/already fixed

Github Project (15/15 points)

• There are four columns (backlog, todo, inprogress and done) under project tab
• Proper use of the columns (backlog is the master list of user stories, the other three columns are broken down tasks to realize/deliver those user stories)

Feedback

• Good

Implementation (39/45 points)

• Planned user stories for this iteration successfully implemented.
• The app should now be beyond CRUD!

Feedback

• In general, very nice implementation. It is nice to see that you have fixed some of the integration issues from previous iterations, and good job on successfully implementing one of your beyond CRUD designs. I will just mention some of the minor bugs that I have found.
• When you try to enter a location on the add event page, the app will crash.
• The repeat function on the add event page does not work.
• For the same course on the calendar, if you click on different days, the block will show as different colors.
• Manually added events will show up on the iOS calendar, but not courses fetched from SIS.
• I noticed that on the home page, when it is like 2AM-ish, it will show that the cafeterias are open right now until their closing time for the day. Double check how you determined if the current time is within the opening time.
• The favorite button display bug still exists.
• Have you tried testing your recommendation algorithm with different locations? I was unable to fully test it but from the code it seems like you hard-coded a location.
• I will expect a bit more for your other beyond CRUD feature, recommendation based on liked activities. It seems like for your location recommendation right now is using a hard-coded location and performing a filter based on distance (Correct me if I am wrong).
• Search for activity now only works by title and no longer location, is this intended?
• User profile page still broken, crashes if clicked on (I know this was not part of your it3 plan, just bringing it to your attention).
• Will users be able to add their own courses through SIS API?
• At this rate, I am a little bit concerned about your progress.

README (5/5 points)

• README included:
  • provides info about the app
  • provides info how to run the app
  • Complies with the provided format
  • etc.

Feedback

• Good, reminder to update video demo

Individual Contribution Report (0 points but Mandatory)

Comments

Things Done Well

Things That Can Be Improved

Other Comments

Total: 83/90

Advisor Name: Shanelle

[darvishdarab]

Updated Feedback:

Iteration 3 (85/90 Points)

Retrospective (5/5 points)

- Good

Software Requirement Specification (5/5 points)

• All sections are up-to-date
  • Problem Statement
  • Proposed Solution
  • Potential Clients
  • Must Haves
  • Nice to Haves
  • Architecture & Technologies

Feedback

• Good

Class Diagram (4/5 points)

• Must use correct UML notation
• The class diagram is in-sync with stated user stories listed and system requirements listed in SRS.

Feedback

• I am assuming that your UML did not change from it2, but reminder to still upload a UML diagram for it3, even if it is the exact same copy. Same for SRS.

Git Activities (10/10 points)

Feedback

• Good
• Remember to check your issues tab, some of the opened issues seems to be outdated/already fixed

Github Project (15/15 points)

• There are four columns (backlog, todo, inprogress and done) under project tab
• Proper use of the columns (backlog is the master list of user stories, the other three columns are broken down tasks to realize/deliver those user stories)

Feedback

• Good

Implementation (41/45 points)

Feedback

• In general, very nice implementation. It is nice to see that you have fixed some of the integration issues from previous iterations, and good job on successfully implementing one of your beyond CRUD designs. I will just mention some of the minor bugs that I have found.
• When you try to enter a location on the add event page, the app will crash.
• The repeat function on the add event page does not work.
• For the same course on the calendar, if you click on different days, the block will show as different colors.
• Manually added events will show up on the iOS calendar, but not courses fetched from SIS.
• I noticed that on the home page, when it is like 2AM-ish, it will show that the cafeterias are open right now until their closing time for the day. Double check how you determined if the current time is within the opening time.
• The favorite button display bug still exists.
• Have you tried testing your recommendation algorithm with different locations? I was unable to fully test it but from the code it seems like you hard-coded a location.
• Search for activity now only works by title and no longer location, is this intended?
• User profile page still broken, crashes if clicked on (I know this was not part of your it3 plan, just bringing it to your attention).
• Will users be able to add their own courses through SIS API?
• At this rate, I am a little bit concerned about your progress.

README (5/5 points)

• README included:
  • provides info about the app
  • provides info how to run the app
  • Complies with the provided format
  • etc.

Feedback

• Good, reminder to update video demo

Individual Contribution Report (0 points but Mandatory)

Comments

Things Done Well

Things That Can Be Improved

Other Comments

Total: 85/90

Advisor Name: Shanelle