jhuapl-bio / Basestack

Basestack is a platform for rapid and real time analysis of NGS data. It provides a executable application that connects standard bionformatics tools to a user interface. It is usable on all major Linux distributions, Mac OS, and Windows 10 or later
https://basestackwebsite.readthedocs.io/en/latest/
GNU General Public License v3.0
26 stars 1 forks source link

Radio and Checkbox form elements #140

Open timuism opened 2 years ago

timuism commented 2 years ago

This PR Includes components to add refactored inputs and checkboxes to basestack.

I started using a pattern inspired from laravel, with x-components (x-checkbox, x-radio, x-fieldset). I think it may be worth using an x-component pattern on global components. I've gone back and forth on the idea so maybe we should discuss it but components like button, textarea, input, label that have a HTML tag of the same name, I like having a simple name and a simple indication that this is a component.

Also in this PR:

ahansrisuk commented 2 years ago

Overall looks good. The styling on these components looks great, I did not know Tailwind had a forms plugin.

I would just verify the data in the form is correct, otherwise it's good to go!