search

jhuapl-boss / boss-oidc

Django Auth plugin specific to the Boss SSO Server
Apache License 2.0
13 stars 22 forks source link

Cleanup #31

Closed derek-pryor closed 5 years ago

derek-pryor commented 5 years ago

Cleaned up plugin packaging and added unit tests.

Also made the install dependencies more generic so as to work with any supported version of Django. Currently guarded to < 2.0 because there are some differences in Django 2.x that make django-oidc / drf-oidc-auth fail.

derek-pryor commented 5 years ago

Adding support for running django migrations via a custom setup.py command

derek-pryor commented 5 years ago

Good catch. I'll add docstrings.

On Thu, Jan 24, 2019 at 6:44 AM Tim Gion notifications@github.com wrote:

@movestill approved this pull request.

It'd be nice if backend.py's methods had param info in their docstrings. Noticed that some of its methods have type hints.

Looks like you put together a good number of tests which is awesome.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jhuapl-boss/boss-oidc/pull/31#pullrequestreview-196064270, or mute the thread https://github.com/notifications/unsubscribe-auth/AO6WUyvm_vssHVo3aRpZFaQ_-sRCZv9nks5vGcbmgaJpZM4aPw7y .