Drop dependency on PyPI mock package

jhuapl-boss / intern

Python SDK for interacting with the BossDB REST API

Apache License 2.0

21 stars 15 forks source link

Drop dependency on PyPI mock package #106

Closed musicinmybrain closed 1 year ago

musicinmybrain commented 1 year ago

Use unittest.mock (available in Python 3.3+) instead. See also: https://fedoraproject.org/wiki/Changes/DeprecatePythonMock

j6k4m8 commented 1 year ago

This looks good to me — thank you @musicinmybrain for contributing! The failing github actions aren't your fault (that's our slack notification stuff breaking because you're not a member of the jhuapl-boss org), and everything appears to be passing in unittests; @movestill thoughts? Otherwise let's merge!

j6k4m8 commented 1 year ago

Awesome — gonna merge this then, and we can run through the imports in a future PR; thanks again @musicinmybrain!

musicinmybrain commented 1 year ago

Nice! Glad this was appreciated.