search

jhuckaby / magic-sorting-system

A data pack for Minecraft 1.13, 1.14 and 1.15 (Java) for automatically sorting every item in the game.
39 stars 15 forks source link

Conflicts with existing item frames #16

Open jhuckaby opened 4 years ago

jhuckaby commented 4 years ago

From Curse user GatKong:

I tried this in a store house I have on my server, and items were ending up on the floor in areas that were decorated with frames, but not the intended sorting frames. In short, it teleports things to ANY item frame that matches the item sorting type. Especially on multi-player servers, you can't always control who puts a frame where to avoid this problem. This means items can be lost if there is a frame in range but not the frame you meant to be the sorting frame. It should look exclusively for item frames with a hopper under them.

groovy-d commented 4 years ago

it does have an upside. I put one with my cobblestone over a lava pit 12 double chests of cobble is fine for me :) But yeah, something else might be a better thing on MP servers. perhaps signs with specific text on them comes to mind

groovy-d commented 4 years ago

just a thought, what about a 'hopper' with a check list of what you want to go into it? By default everything is turned off. but you check boxes (or something) that make it accept those specific items or categories. Like I said, just a thought.

isaaclepes commented 4 years ago

I re-wrote this datapack for other functionality I wanted. I ended up using custom named items that when inserted into the frame primes it by applying a tag. Only tagged frames can be used for teleport targets. Feel free to have a look through my fork. Since I forked my project out of this, feel free to borrow any of the changes I made.

Note, I don't want other users on my server to setup these targets, so I used command blocks and barrier blocks to ensure only operators could access it. A small re-write would make this survival-player accessible again.