Closed avahoffman closed 2 years ago
No spelling errors! :tada: Comment updated at 2022-08-09 with changes from 1e3040b753708ff657f19284b23ee82cd4b790a0
No broken URLs detected! :tada: Comment updated at 2022-08-09 with changes from 1e3040b753708ff657f19284b23ee82cd4b790a0
Re-rendered previews from the latest commit:
Updated at 2022-08-09 with changes from 1e3040b753708ff657f19284b23ee82cd4b790a0
Ah, good point. I was removing them so we weren't cluttering up the new repos with the demo module chapters, that they'd just have to delete.
How hard would it be to have starting-course.yml
replace _bookdown.yml? If you think that's more trouble than it's worth, I'm fine going this route, keeping the .Rmds and letting the course authors deal with deleting them.
@KatherineCox I don't think it would be hard to replace with the starting-course workflow .. but I could definitely see myself using 4-6 and it doesn't bother me too much that there are lots of Rmds to start. Honestly, it's kind of nice to be reminded those workspace etc. modules exist 🙂
Ok then, I'm good with leaving them.
When this template is used, it tries to render all the files listed in _bookdown.yml. However, the starting-course workflow removes Rmds 4-6. This causes a render failure unless the user knows to delete these files from _bookdown.yml.
https://github.com/jhudsl/AnVIL_Template/blob/c21b669621482208bb50add9c36915d8ab47fbde/_bookdown.yml#L4-L12
Removing these files from the list in starting-course.yml keeps them when the newly cloned repo is cleaned up.
https://github.com/jhudsl/AnVIL_Template/blob/c21b669621482208bb50add9c36915d8ab47fbde/.github/workflows/starting-course.yml#L38-L42