Taking a look at the theme

[avahoffman]

Worked on the theming for GDSCN a bit - the green for the main headers was kind of light and I think this is more readable.

Appreciate any additional thoughts @KatherineCox @ehumph ! Here's a preview (won't show up on the link below since it uses the AnVIL theme by default)

[github-actions[bot]]

No broken urls! :tada: Comment updated at 2023-03-06 with changes from f2ab5141e2e36439540539380a9f36bb4bad49cf

[github-actions[bot]]

No spelling errors! :tada: Comment updated at 2023-03-06 with changes from f2ab5141e2e36439540539380a9f36bb4bad49cf

[github-actions[bot]]

Re-rendered previews from the latest commit:

• See preview of Bookdown here
• See preview of Coursera/Leanpub version here
• Download the preview of the Student Guide .docx file

Updated at 2023-03-06 with changes from f2ab5141e2e36439540539380a9f36bb4bad49cf

[KatherineCox]

@avahoffman Nice! It's been on my wishlist to do something like this. Looks great! My only comment is, instead of changing the css colors in place, I would override them at the bottom of the file, so that it's easier to maintain.

I had just noticed some of our GDSCN-specific stuff was not set up like this, and was working on moving things to the end of the file as part of integrating in the new OTTR updates in #195

[avahoffman]

@avahoffman Nice! It's been on my wishlist to do something like this. Looks great! My only comment is, instead of changing the css colors in place, I would override them at the bottom of the file, so that it's easier to maintain.

I had just noticed some of our GDSCN-specific stuff was not set up like this, and was working on moving things to the end of the file as part of integrating in the new OTTR updates in #195

Makes sense! Will fix.

[avahoffman]

@KatherineCox I am working on a possible solution here: https://github.com/jhudsl/ottrpal/pull/115 FYI! The goal is that one would be able to use multiple css files in both the regular and ToC-less versions.

[ehumph]

@avahoffman I am a little worried that the black and green color scheme won't work for people who are red-green colorblind. It might not be a problem - the green is just going to be indistinguishable from the black for some people - though it's nice to have the different colors on the side menu. It's probably a bit late for me to worry about this, since the original color scheme is green and black too.

[avahoffman]

@ehumph thanks for raising this. I think the only changes are from dark blue --> dark green and light blue --> light green. So they should hopefully still be distinguishable.

Not sure if this is 100% accurate, but here's a simulation of no green color vis:

monochrome:

Think this will work?

[KatherineCox]

@KatherineCox I am working on a possible solution here: jhudsl/ottrpal#115 FYI! The goal is that one would be able to use multiple css files in both the regular and ToC-less versions.

Awesome! That would be great, to be able to split things out into separate files.

[ehumph]

Looks good to me!