jhudsl / AnVIL_Template

An OTTR spinoff template for creating AnVIL content
https://jhudatascience.org/AnVIL_Template/
Creative Commons Attribution 4.0 International
0 stars 1 forks source link

Testing out the newly implemented multi-css capability #198

Closed avahoffman closed 1 year ago

avahoffman commented 1 year ago

in response to https://github.com/jhudsl/ottrpal/pull/115

@KatherineCox @cansavvy I think this is working as expected!

Let's see how this one goes before

I am about 80% sure the following chunk is okay to take out, due to the restored file path. If I'm wrong, I will fix :)

/* fix the image urls since our AnVIL style is in a different location */
/* images paths are relative to the CSS file */

div.notice{
  background-image: url("../box_images/note.png");
}

div.warning{
  background-image: url("../box_images/warning.png");
}

div.github{
  background-image: url("../box_images/github.png");
}

div.dictionary{
  background-image: url("../box_images/dictionary.png");
}

div.reflection{
  background-image: url("../box_images/thinking_face.png");
}
github-actions[bot] commented 1 year ago

No broken urls! :tada: Comment updated at 2023-03-09 with changes from 92ac44bdef86d1a33730c8c7d2c1349a271470b7

github-actions[bot] commented 1 year ago

No spelling errors! :tada: Comment updated at 2023-03-09 with changes from 92ac44bdef86d1a33730c8c7d2c1349a271470b7

github-actions[bot] commented 1 year ago

Re-rendered previews from the latest commit:

Updated at 2023-03-09 with changes from 92ac44bdef86d1a33730c8c7d2c1349a271470b7

avahoffman commented 1 year ago

She works! Added an "ugly" color mod.

Regular: Screen Shot 2023-03-09 at 5 50 30 PM No ToC: Screen Shot 2023-03-09 at 5 50 45 PM

KatherineCox commented 1 year ago

I'll take a look at everything when I'm at my computer, but yes, you should be good to drop those file paths 👍. I had to add them when I moved the style file down into the AnVIL assets directory, since paths are relative to the location of the css file.

Related, we'll want to update the sync.yml file in OTTR_Template so that the OTTR style.css file is syncing to the correct AnVIL_Template file.

Yay! This is exciting! Awesome work!!!

avahoffman commented 1 year ago

This makes sense to me! As long as it looks like it is working to you. One last step we’ll need to do is push the latest base_ottr docker image to have the main tag if we have confirmed the ottrpal updates are working as expected.

Yes definitely. Would you rather (1) wait a bit to see if this causes any trouble here, or (2) just push now with the option to revert if need be? I am ok yolo'ing the image if you are!

avahoffman commented 1 year ago

Well poop - needed to update render-all.yml as well 😛 : #199