search

jhudsl / AnVIL_Template

An OTTR spinoff template for creating AnVIL content
https://jhudatascience.org/AnVIL_Template/
Creative Commons Attribution 4.0 International
0 stars 1 forks source link

Updating the files that need to be considered with `sync.yml` #202

Closed avahoffman closed 1 year ago

avahoffman commented 1 year ago

Updating the files that we want to push out to sync.

I think all of these make sense. Not sure if we need ottr-fy.R?

IMPORTANT:

config_automation.yml needs to be updated to use the updated docker image:

rendering-docker-image: 'jhudsl/base_ottr:main'
github-actions[bot] commented 1 year ago

No broken urls! :tada: Comment updated at 2023-03-22 with changes from afd4771ed03dc8397f765c5f78c38b517da334c7

github-actions[bot] commented 1 year ago

No spelling errors! :tada: Comment updated at 2023-03-22 with changes from b6da5ed6e267b4479f8e4883a20cbf5a0a6c3cd4

github-actions[bot] commented 1 year ago

Re-rendered previews from the latest commit:

Updated at 2023-03-22 with changes from b6da5ed6e267b4479f8e4883a20cbf5a0a6c3cd4

KatherineCox commented 1 year ago

So, the reason I had asset files and subdirectories listed out individually instead of just syncing the whole assets directory was in case any downstream repos decided to put some of their own book-specific assets in the assets directory. I didn't want to clobber them or make PRs harder. Not sure how often that'll happen in reality?

avahoffman commented 1 year ago

The only one I found was the gdscn word doc template. Happy to change it back.

KatherineCox commented 1 year ago

Haha, I'm too slow with my comments :) Either way is fine with me.

avahoffman commented 1 year ago

hehe! I think it's probably the most cautious solution. I'm on board :)

KatherineCox commented 1 year ago

Closes #196 (does the this work if I add it after the PR has been merged?)

Edit: Nope, it did not automatically close.