jhudsl / OTTR_Template

OTTR for making courses! This is a template repo that helps people write 1 course but publish it in three places
https://www.ottrproject.org/
Creative Commons Attribution 4.0 International
17 stars 14 forks source link

Attempt #2 at making manuscript folder actually delete #644

Closed cansavvy closed 1 year ago

cansavvy commented 1 year ago

Purpose/implementation Section

What changes are being implemented in this Pull Request?

https://github.com/jhudsl/OTTR_Template/pull/643 didn't work.

Next attempt is to commit the rm -rf manuscript/ step before we committ the new files.

cansavvy commented 1 year ago

@cansavvy did this "old version" work?

No, this is a larger problem now with committing to main for all steps in render-all.yml. Looking into how we fix it.

carriewright11 commented 1 year ago

@cansavvy did this "old version" work?

No, this is a larger problem now with committing to main for all steps in render-all.yml. Looking into how we fix it.

oh goodness - confusing...

carriewright11 commented 1 year ago

I am happy to help more but it is hard to keep up with what you have looked at...I can meet about this tomorrow if you want.

github-actions[bot] commented 1 year ago

Re-rendered previews from the latest commit:

Updated at 2023-05-24 with changes from c4537662e75771573b3429126b2a631dda856d96

github-actions[bot] commented 1 year ago

No spelling errors! :tada: Comment updated at 2023-05-24 with changes from c4537662e75771573b3429126b2a631dda856d96

github-actions[bot] commented 1 year ago

No broken urls! :tada: Comment updated at 2023-05-24 with changes from c4537662e75771573b3429126b2a631dda856d96

cansavvy commented 1 year ago

I am happy to help more but it is hard to keep up with what you have looked at...I can meet about this tomorrow if you want.

I wrote this in slack but not here. A lot of the reason I thought this was failing was that my test I was using (manual workflow dispatch on the development branch) was not a good test. But when merged to main things work fine.