Closed avahoffman closed 3 months ago
No spelling errors! :tada: Comment updated at 2024-06-04-17:36:57 with changes from 370f48a5d9193536fd495a486046d2d310d7139e
The broken url errors check is currently being re-run :runner: Comment updated at 2024-06-04-17:36:04 with changes from 370f48a5d9193536fd495a486046d2d310d7139e
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.
Updated at 2024-06-04 with changes from the latest commit 370f48a5d9193536fd495a486046d2d310d7139e
--rebase
does feel like a lot. I'm not concerned about using it on the preview branch because it is a throw away branch, but have to think a bit more about using rebase with the main branch. Hmmm...
I think if it works I'd like to try a less drastic fix first which is what we implemented on Chris's Intro to R repo: https://github.com/fhdsl/Intro_to_R/pull/41
I think implementing to the preview branch we should definitely go ahead with! Thanks @avahoffman
But it needs to be added to ottr-reports to be effective. (this is why the URL checker is still failing) See this PR: https://github.com/jhudsl/ottr-reports/pull/36
Done!
I think we gotta do rebase. My other less drastic solutions aren't working. I think it should be fine though? It's only for the docs folder we will be doing this.
What I still don't understand is why this just came up as an issue and wasn't an issue previously. What's changed?
Okay I have one more try.
Never mind. Let's merge this.
@cansavvy I imagine one of the actions, perhaps checkout, has been updated or changed?
I actually think rebase might be appropriate (and not too aggressive) here, since all the changes executed by the rendering steps should always supersede any changes on main
. Trying to think of a situation where it could be problematic.
@cansavvy I imagine one of the actions, perhaps checkout, has been updated or changed?
I actually think rebase might be appropriate (and not too aggressive) here, since all the changes executed by the rendering steps should always supersede any changes on
main
. Trying to think of a situation where it could be problematic.
Yeah I agree on all of this. I think you're right. Just was worried about moving to fast on something that maybe had potentially to be messy, but I think its good.
Problem
example
Solution
I've found
--rebase
helps with this. But not sure if it's overkill. Welcome everyone's thoughts!