Post workshop - Githubissues

jhudsl / OTTR_Template_Website

Template to create websites with checks for broken urls and spelling, as well as automated rendering.

https://www.ottrproject.org/

MIT License

2 stars 3 forks source link

Post workshop #37

Closed carriewright11 closed 2 years ago

carriewright11 commented 2 years ago

I had intended to add this before the workshop, but things were a bit hectic.

adding more images about what the checks look like
adding more info about what to do about them
adding info about merging PRs (thank you to Tom for that too!)

github-actions[bot] commented 2 years ago

No spelling errors! :tada: Comment updated at 2022-09-21 with changes from 7d94b7e99b810f33b0ff6c3b307b9d0c899a8c8d

github-actions[bot] commented 2 years ago

Re-rendered previews from the latest commit: See preview of website here

Updated at 2022-09-21 with changes from 7d94b7e99b810f33b0ff6c3b307b9d0c899a8c8d

github-actions[bot] commented 2 years ago

No broken URLs detected! :tada: Comment updated at 2022-09-21 with changes from 7d94b7e99b810f33b0ff6c3b307b9d0c899a8c8d

cansavvy commented 2 years ago

So... the URL checker is working, but it technically doesn't see these URLs as broken. This is a bigger issue than this PR. I've filed this issue here: https://github.com/jhudsl/OTTR_Template/issues/563

So for now, I think this PR can be merged after we get rid of the URLs that are 'broken' in the practical sense but not according to the test we are using.

carriewright11 commented 2 years ago

So... the URL checker is working, but it technically doesn't see these URLs as broken. This is a bigger issue than this PR. I've filed this issue here: jhudsl/OTTR_Template#563

So for now, I think this PR can be merged after we get rid of the URLs that are 'broken' in the practical sense but not according to the test we are using.

OK sounds good... I will still add one that does make it fail so I can add some information about that to the git action page