search

jhudsl / ari

:dancers: The Automated R Instructor
https://jhudatascience.org/ari/
Other
146 stars 37 forks source link

subtitles #25

Closed nsacco closed 3 years ago

nsacco commented 4 years ago

I wonder if the function "ari_burn_subtitles" is working. I can burn in a very clumsy way subtitles with the bash, but when I try to run that function I get this Error in RStudio: could not find function "ari_burn_subtitles"

elinw commented 3 years ago

It seems not to be exported, so I found you could access it with ari:::ari_burn_subtitles but I couldn't get it to work (thus far). I believe the issue is that this code is in the function:

paste(ffmpeg, "-y -i", video, paste0("-vf subtitles=", 
        srt), video)

ffmpeg can't read and write to the same file, so this won't work ... either it needs a second argument with the output name or else it needs to generate a new name automatically. when I tried this function in the terminal (without the paste0) it pretty much worked, but the narration was too long and just the first line was on each slide.

muschellij2 commented 3 years ago

Closing stale issue - please reopen if needed.