search

jhudsl / ari

:dancers: The Automated R Instructor
https://jhudatascience.org/ari/
Other
146 stars 37 forks source link

Burn subtitles #52

Closed howardbaek closed 10 months ago

howardbaek commented 11 months ago

Purpose/implementation Section

I wanted to add subtitles to Loqui so I experimented with ari_burn_subtitles()and fixed a bug.

What changes are being implemented in this Pull Request?

The system() command specified the wrong path to the video output. It was specifying the same path for both the input and the output, which ffmpeg didn't like. I changed the path to the video output so we can have different paths for the input and output.

seankross commented 11 months ago

Hey Howard, is there any reason we shouldn't be comparing this PR against the main branch?

howardbaek commented 11 months ago

@seankross Technically, this can be compared against the main branch. I'm comparing it against the ariExtra-immigration branch because Loqui uses ari functions in that branch and not the main branch.