search

jhudsl / ariExtra

Tools for Creating Automated Courses
GNU General Public License v3.0
6 stars 4 forks source link

Improved function syntax #5

Closed howardbaik closed 1 year ago

howardbaik commented 1 year ago

Added titles to every function and inline comments to explain what each function is doing.

cansavvy commented 1 year ago

Ah, the checks are failing here because this also needs the version bumps akin to what we did here: https://github.com/jhudsl/ari/pull/43

Do you want to sneak that in here?

howardbaik commented 1 year ago

I just bumped up the version and deleted the two .yml files for travis and appveyor!

cansavvy commented 1 year ago

May also need to bump up r-lib/actions/check-r-package@v1 ?

howardbaik commented 1 year ago

@cansavvy I bumped up the version from r-lib/actions/check-r-package@v1 to r-lib/actions/check-r-package@v2, but the R-CMD-check / windows-latest is still failing, and I have no idea what this error message is saying:

https://github.com/jhudsl/ariExtra/actions/runs/4813676124/jobs/8570505579?pr=5

cansavvy commented 1 year ago

One of the tests for one of the functions is failing. We can try to look into why. I'll make a separate issue for that. And we can merge this pr.

cansavvy commented 1 year ago

Filed: https://github.com/jhudsl/ariExtra/issues/6