search

jhudsl / matahari

🔎 I Spy With My Little Eye
Other
49 stars 6 forks source link

Final things 🎉 #13

Closed LucyMcGowan closed 5 years ago

LucyMcGowan commented 5 years ago

@seankross this has the vignette & pkgdown site. I think once this is merged it may be ready for a CRAN submit! I didn't update any versioning because I wasn't quite sure what the system you prefer is, but let me know if you want me to bump that.

seankross commented 5 years ago

This looks really good to me! The version number I will submit to CRAN will be 0.1.0 if that's okay with you, and I will change all of the mentions of the version accordingly. Let me know when you're ready then I will take care of all the pre-CRAN testing details, then I will submit it :)

LucyMcGowan commented 5 years ago

Perfect! That version sounds great, I’m ready! Thank you for submitting! Let me know when it goes through and I’ll submit tidycode!

seankross commented 5 years ago

Just submitted! 🤞