Not able to initiate dance without removing first

jhudsl / matahari

🔎 I Spy With My Little Eye

Other

49 stars 6 forks source link

Not able to initiate dance without removing first #20

Closed LucyMcGowan closed 4 years ago

LucyMcGowan commented 4 years ago

This code is creating an issue where you need to run dance_remove() in order to run dance_start() again (which I don't think we intended?) before you could just run

dance_start()
dance_stop()

https://github.com/jhudsl/matahari/blob/834885d06dd3496b6741d4a5932d5e35173e878c/R/dance.R#L40-L42

seankross commented 4 years ago

This should be fixed in #21. Would you mind testing it out for me?

remotes::install_github("jhudsl/matahari@dev")

LucyMcGowan commented 4 years ago

Fabulous, just tried it and it looks good :+1: Thank you, @seankross you're the best!