search

jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Bug fixes #113

Closed cansavvy closed 1 year ago

cansavvy commented 1 year ago

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Addressing a few bug fixes:

  1. Make it so Administrative Checks fixes aren't needed by allowing fill in the blank questions
  2. Make it so that numbered questions are also acceptable and don't set off a warning
  3. Create a new ignore_coursera argument will allow ! and : in question prompts. Only Coursera doesn't allow these.
cansavvy commented 1 year ago

I tested this on the DataTrail Quizzes after deleting the "Administrative Checks" questions as well as the good and bad quiz examples that are included in the R package.

cansavvy commented 1 year ago

@avahoffman would you mind looking over these fixes and seeing if what changes I've made here make sense? No rush.

cansavvy commented 1 year ago
  • Coursera can't have the ! fill in the blank questions, so we want to detect them and raise a warning is that correct?
  • Default behavior is to allow these ! questions

Yes, these items are both correct