jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Accommodate multiple css #115

Closed avahoffman closed 1 year ago

avahoffman commented 1 year ago

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Attempting a solution for https://github.com/jhudsl/OTTR_Template/issues/536. to accommodate:

bookdown::gitbook:
  css: [assets/style.css, assets/AnVIL_style/anvil.css]

What was your approach?

If multiple css files are provided in _output.yml, this now loops through and makes a "mega css" to proceed.

Would appreciate if others can test/gut check this!

cansavvy commented 1 year ago

Thanks for doing this @avahoffman ! I'm gonna give this a deeper look tomorrow and get back to you.

avahoffman commented 1 year ago

Sounds great! I am hoping to be done with messing around with our AnVIL css :)

cansavvy commented 1 year ago

Thanks for doing this @avahoffman ! I'm gonna give this a deeper look tomorrow and get back to you.

This was a lie. 🤣

cansavvy commented 1 year ago

What repositories can I test this on? Does AnVIL_Template work as a good test?

cansavvy commented 1 year ago

Also, after this does run, what can I look at in your rendered AnVIL_Template to know that the multiple css files have all been incorporated? I'm not sure what I'm looking for. @avahoffman

avahoffman commented 1 year ago

Good question haha. I tested it with toc-less.css and an 'anvil.css' both as args on _output.yml. 'anvil.css' had some css that changed the color and it appeared to work. I'll test further with a test docker image.

cansavvy commented 1 year ago

Sounds great. If that test docker image run works, then feel free to update the :main tagged docker image on jhudsl/base_ottr. Or I can also do that.

avahoffman commented 1 year ago

@cansavvy I will take care of it :)