jhudsl / ottrpal

Tools for converting OTTR courses into Leanpub or Coursera courses :otter:
https://jhudatascience.org/ottrpal/
GNU General Public License v3.0
3 stars 1 forks source link

Resolve dependency on self #124

Closed avahoffman closed 5 months ago

avahoffman commented 5 months ago

Ran into the issue of calling ottrpal::render_without_toc which depends on ottrpal::bookdown_path and getting an inscrutable message in github actions. Basically, it's not finding the path.

Going to do a quick test and make sure this works.

avahoffman commented 5 months ago

Update: works when I run in test! 🤩

      # Run TOC-less version
      # Rendered content for Leanpub and Coursera is very similar.
      # This job creates a shared scaffold for both.
      - name: Run TOC-less version of render
        id: tocless
        run: Rscript -e "devtools::install_github('jhudsl/ottrpal', ref = remotes::github_pull('124'), upgrade = 'never'); ottrpal::render_without_toc()"
        env:
          GITHUB_PAT: ${{ secrets.gh_pat }}

https://github.com/fhdsl/DaSL_Collection/actions/runs/7714824042

cansavvy commented 5 months ago

Thanks for fixing this and also showing how you tested it!! Seems good to me!